On Fri, Jan 31, 2025 at 02:47:27PM +0100, Claudio Jeker wrote:
> So some time ago we added a MSG_ prefix to enum msg_type because
> NOTIFICATION caused a conflict with the bison produced parse.y file.
> 
> Now MSG_NOTIFICATION is again causing a conflict but this time with a
> define in sys/socket.h on some systems. It seems that SCPT introduced this
> into the socket API.

I won't comment on SCTP. I also never heard of an issue that revolved
around including the label's terminating NUL or not when computing the
shared secret.

> So lets use BGP_ as a prefix instead of MSG_. Hopefully this time nobody
> else defines BGP_NOTIFICATION for some doubious reason.

I think it's safe. pmacct and upstream tcpdump use these same defines
while including socket.h and tons of other things.

ok tb