On Mon, Feb 17, 2025 at 04:26:47PM +0100, Claudio Jeker wrote:
> Tripped over this today. min_holdtime and holdtime are both in the global
> bgpd_config and in the peer_config. If the value in peer_config is 0 then
> the global value should be used.
> 
> The problem is this is only done for holdtime but not for min_holdtime.
> I realy dislike this either or handling inside message processing code
> and decided to instead set the peer_config holdtime and min_holdtime value
> in init_peer() so the rest of the code does not need to care. Only during
> config reloads we need to reapply the values again since the config is
> copied over and so it is set back to 0.
> 
> The below diff does that.

Makes sense and reads fine.

ok tb