On Fri, 28 Feb 2025 10:20:04 +0100,
Landry Breuil <landry@openbsd.org> wrote:
> 
> Le Thu, Feb 27, 2025 at 08:21:25PM +0100, Kirill A. Korinsky a écrit :
> > tech@,
> > 
> > I'd like to add support of USB3 speeds to XHCI driver.
> > 
> > This diff was tested on Snapdragon SoC:
> > 
> > 	xhci0 at qcdwusb0, xHCI 1.10
> > 	usb0 at xhci0: USB revision 3.0
> > 	uhub0 at usb0 configuration 1 interface 0 "Generic xHCI root hub" rev 3.00/1.00 addr 1
> > 
> > I also used diff: https://marc.info/?l=openbsd-tech&m=174032299500347&w=2
> > and switched Elgato Facecam Pro to isochronous mode with streaming
> > 3840x2160 30fps with 33740 isoc frames / packets.
> 
> i see the intent is to make it work with cameras, but shouldnt just
> adding support for USB3 speeds also benefit to transfer speeds for other
> usb devices (eg usb keys) ?
> 

Here two kind endpoints: bulk and isochronous. Bulk already works with USB3
speed, and both patches is required only for isochronous.

Seems that only uvideo, utvfu, uaudio and ugen uses that endpoints. I see
that wMaxPacketSize is used only in uvideo, utvfu and ugen.

Seems that extract uvideo_vc_parse_max_packet_size as generic function and
use it at utvfu and ugen is possible the next step, but I not sure that it
realy needed.

-- 
wbr, Kirill