On 2025/03/05 18:21, Bryan Vyhmeister wrote:
> On Wed, Mar 05, 2025 at 06:03:42PM -0800, Bryan Vyhmeister wrote:
> > On Wed, Mar 05, 2025 at 06:36:29PM -0700, Theo de Raadt wrote:
> > > Bryan Vyhmeister <bryan@bsdjournal.net> wrote:
> > > 
> > > Does not need to say NVME
> > > 
> > > That is wasting bytes.  Look at your dmesg to see how it looks.
> > 
> > Good point. Updated diff below. Should I fix all the Samsung IDs that
> > have NVMe on the end?
> 
> Here is a diff that removes NVMe from all the Samsung, SanDisk/Western
> Digital, and an SMI NVMe. It also includes the SK hynix SSDs this thread
> has been about without NVMe. Should I remove the _NVME from a lot of the device
> strings (not the descriptions)?

Those are just used to create preprocessor macros, they don't make it
into the kernel - I would prefer to leave them.