Index | Thread | Search

From:
Stuart Henderson <stu@spacehopper.org>
Subject:
Re: Device errors with Xeon w5-2545
To:
Jan Klemkow <jan@openbsd.org>
Cc:
Mark Kettenis <mark.kettenis@xs4all.nl>, tech@openbsd.org
Date:
Fri, 14 Mar 2025 10:31:34 +0000

Download raw body.

Thread
On 2025/03/14 11:22, Jan Klemkow wrote:
> On Fri, Mar 14, 2025 at 10:45:49AM +0100, Mark Kettenis wrote:
> > In any case a change in this area needs thorough testing.
> 
> That's right.  I guess this will some other strange hardware problems
> out there.  Any tests are welcome!

I'll look for a few places to try it.

Around now (i.e. in 7.7-beta) would actually seem a good time for
getting reasonable test coverage via snapshots (or possibly commit) ...

> Thanks,
> Jan
> 
> Index: dev/acpi/acpi.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/acpi/acpi.c,v
> diff -u -p -r1.443 acpi.c
> --- dev/acpi/acpi.c	11 Feb 2025 16:22:37 -0000	1.443
> +++ dev/acpi/acpi.c	14 Mar 2025 10:13:54 -0000
> @@ -3237,7 +3237,9 @@ acpi_foundhid(struct aml_node *node, voi
>  		return (0);
>  
>  	sta = acpi_getsta(sc, node->parent);
> -	if ((sta & (STA_PRESENT | STA_ENABLED)) != (STA_PRESENT | STA_ENABLED))
> +	if (!ISSET(sta, STA_PRESENT) && !ISSET(sta, STA_DEV_OK))
> +		return (1);
> +	if (!ISSET(sta, STA_ENABLED))
>  		return (0);
>  
>  	if (aml_evalinteger(sc, node->parent, "_CCA", 0, NULL, &cca))
>