Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: clear ice(4) OACTIVE flag on reset
To:
Alexander Bluhm <bluhm@openbsd.org>, tech@openbsd.org
Date:
Thu, 3 Apr 2025 18:25:55 +0200

Download raw body.

Thread
On Thu, Apr 03, 2025 at 06:11:11PM +0200, Stefan Sperling wrote:
> I will simplify my ice(4) diff accordingly.

The simplified ice(4) fix looks much like the ixl(4) one:

M  sys/dev/pci/if_ice.c  |  2+  0-

1 file changed, 2 insertions(+), 0 deletions(-)

commit - e674ff4efec7cbf97d8e840abe7d4932a91406a2
commit + 38a7fef2a38ba804a2c426c23c726bbc22061ead
blob - bd0dce1b0ea933c29b54da3b432b5fb3e4eac94e
blob + 62f91aa53200840c7c961abd266a05e82726eaa6
--- sys/dev/pci/if_ice.c
+++ sys/dev/pci/if_ice.c
@@ -13400,6 +13400,8 @@ ice_txq_clean(struct ice_softc *sc, struct ice_tx_queu
 	}
 
 	txq->txq_cons = txq->txq_prod = 0;
+
+	ifq_clr_oactive(txq->txq_ifq);
 }
 
 void