Index | Thread | Search

From:
Jan Stary <hans@stare.cz>
Subject:
drop a useless function
To:
tech@openbsd.org
Date:
Mon, 7 Apr 2025 21:20:14 +0200

Download raw body.

Thread
The tformat() function in zdump.c
merely returns a constant string
and is called once.

	Jan


Index: zdump.c
===================================================================
RCS file: /cvs/src/usr.sbin/zdump/zdump.c,v
diff -u -p -r1.14 zdump.c
--- zdump.c	15 Mar 2016 19:50:48 -0000	1.14
+++ zdump.c	7 Apr 2025 19:18:33 -0000
@@ -62,7 +62,6 @@ static void		dumptime(const struct tm *t
 static time_t		hunt(char *name, time_t lot, time_t	hit);
 static void		setabsolutes(void);
 static void		show(char *zone, time_t t, int v);
-static const char 	*tformat(void);
 static time_t		yeartot(long y);
 static void		usage(void);
 
@@ -358,7 +357,7 @@ show(char *zone, time_t t, int v)
 	if (v) {
 		tmp = gmtime(&t);
 		if (tmp == NULL) {
-			printf(tformat(), t);
+			printf("%lld", t);
 		} else {
 			dumptime(tmp);
 			printf(" UTC");
@@ -398,12 +397,6 @@ abbr(struct tm *tmp)
 ** The code below can fail on certain theoretical systems;
 ** it works on all known real-world systems as of 2004-12-30.
 */
-
-static const char *
-tformat(void)
-{
-	return "%lld";
-}
 
 static void
 dumptime(const struct tm *timeptr)