Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
Re: Count m_pool_alloc() failures in netstat -m
To:
Theo de Raadt <deraadt@openbsd.org>
Cc:
Stefan Fritsch <sf@sfritsch.de>, tech@openbsd.org
Date:
Tue, 10 Jun 2025 16:24:13 +0200

Download raw body.

Thread
On Tue, Jun 10, 2025 at 08:02:02AM -0600, Theo de Raadt wrote:
> Stefan Fritsch <sf@sfritsch.de> wrote:
> 
> > Diff below. Does one need to do something special when changing the sysctl 
> > structs? Comments, opinions?
> 
> It will be a subtle and small ABI breakage between the kernel and the
> netstat binary, but I don't see anything else actually looking at the
> fields in the structure.  It is extremely unlikely anything in ports
> looks at any fields, and will notice their positions have changed.
 
I think best would be to just replace the fields with pads. There is some
rather bad code in golang and rust. We may be lucky and nobody pulls those
sysctl structs out yet but e.g. node_exporter is very sloppy since
everyone thinks the ABI will never change.

-- 
:wq Claudio