Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
Re: usbdevs: fix vendor, add device
To:
tech@openbsd.org
Date:
Wed, 18 Jun 2025 09:57:10 +1000

Download raw body.

Thread
On Tue, Jun 17, 2025 at 04:00:19PM -0500, joshua stein wrote:
> 0x1286 appears to be Marvell according to the interwebs and Tenda 
> makes Wi-Fi adapters but probably just uses Marvell chips.

0x1286 / 4742 is the only Marvell vendor id listed on usb.org

> 
> This renames Tenda (which is not in use in any drivers) to a second 
> Marvell vendor and adds an RTL8188EU device.
> 
> 
> diff --git sys/dev/usb/usbdevs sys/dev/usb/usbdevs
> index 7d07d486b72..03f2fdc8ed4 100644
> --- sys/dev/usb/usbdevs
> +++ sys/dev/usb/usbdevs
> @@ -517,7 +517,7 @@ vendor TSUNAMI		0x1241	Tsunami
>  vendor PHEENET		0x124a	Pheenet
>  vendor RAPTORGAMING	0x1267	Raptor Gaming
>  vendor TWINMOS		0x126f	TwinMOS
> -vendor TENDA		0x1286	Tenda
> +vendor MARVELL2		0x1286	Marvell
>  vendor TESTO		0x128d	Testo AG
>  vendor CREATIVE2	0x1292	Creative Labs
>  vendor BELKIN2		0x1293	Belkin Components
> @@ -2830,6 +2830,8 @@ product MACALLY MOUSE1		0x0101	mouse
>  
>  /* Marvell products */
>  product MARVELL SHEEVAPLUG	0x9e8f	SheevaPlug
> +product MARVELL2 TWL541U	0x1fab	TWL541U WLAN
> +product MARVELL2 8188EU		0x2045	RTL8188EU WLAN

to match existing entries this would be better as

product MARVELL2 RTL8188EU	0x2045	RTL8188EU

ok jsg@ with that change

you tested it with urtwn(4)?

>  
>  /* Matrix Orbital products */
>  product MATRIXORB LCD_0100	0x0100	LCD
> @@ -4461,9 +4463,6 @@ product TEKRAM ZD1211_2		0x6630	ZD1211
>  /* Telex Communications products */
>  product TELEX MIC1		0x0001	Microphone
>  
> -/* Tenda */
> -product TENDA TWL541U		0x1fab	TWL541U WLAN
> -
>  /* Ten X Technology, Inc. */
>  product TENX MISSILE		0x0202	Missile Launcher
>  product TENX TEMPER		0x660c	TEMPer sensor
> 
>