On Tue, Jul 08, 2025 at 11:38:18AM +0200, Theo Buehler wrote:
> On Tue, Jul 08, 2025 at 09:25:37AM +0000, Miod Vallat wrote:
> > The following diff adds missing library dependencies in the Makefile for
> > a few binaries. This is needed, for example, to correctly build static
> > binaries.
> 
> bgplgsh and tcpbench are
> 
> ok tb
> 
> I'm unsure why the cange in ssh-sk-helper is needed. Isn't the NEEDED
> entry for libz in libfido2 enough? (I only checked on amd64 aarch64 and
> sparc64, where it is present).

It's obviously not the NEEDED entries because that's about shared libs.
I assume ssh-sk-helper links fine for me with ld.lld and ld.bfd because
it doesn't seem to use fide_compress/uncompress and the largeblob stuff
that both rely on zlib.

If you say adding these libz dep is the correct thing to do anyway, I'm
ok with that.