Index | Thread | Search

From:
Todd C. Miller <millert@openbsd.org>
Subject:
Re: md5(1): avoid undefined function pointer casts
To:
Theo Buehler <tb@theobuehler.org>
Cc:
tech@openbsd.org
Date:
Wed, 16 Jul 2025 16:14:39 -0600

Download raw body.

Thread
On Wed, 16 Jul 2025 23:46:46 +0200, Theo Buehler wrote:

> Thanks. It did compile. But it would have warn with -Wunused, so it would
> probably be better to guard the wrappers anyway. Using the union forces
> this because the wrappers now try to access union members that the
> preprocessor hides. The diff then looks like this. I don't really have a
> preference, but since the union is already there and passed in, why not.
>
> Regress passes. It hangs, by the way, if the binary is compiled iwth
> SHA2_ONLY. I couldn't immediately see a way to avoid this, but it's
> probably not a problem.

Looks good.  OK millert@

 - todd