On Fri, Jul 25, 2025 at 03:05:44PM +1000, Damien Miller wrote:
> Hi,
> 
> This is a long but mostly mechanical diff to update our PKCS#11 API
> definition header from 2.x to 3.x. I'd like to do this because the 3.x
> API includes definitions for EDDSA, which will let us host Ed25519
> keys in PKCS#11 devices.

Wonder if it's worth it to split this diff into two: one that does the
"let's append UL to everything" noise and one that does the actual
additions, the version crank and the typofix. Would make it much easier
to spot what happened in the revision history.

> ok?

ok

There's a couple of tab vs spaces issues, probably not yours (I haven't
looked for an upstream to check against):

> +/* Flags in Message-based encryption/decryption API */
> +#define CKF_END_OF_MESSAGE 	(0x00000001UL)

Space before tab             ^

> +#define CKR_CURVE_NOT_SUPPORTED          	(0x140UL)

10 spaces before tab              ^^^^^^^^^^