On Sun, 03 Aug 2025 10:03:17 +0200,
Marcus Glocker <marcus@nazgul.ch> wrote:
> 
> The diff looks good to me.  No regressions noticed during quick testing.
> 
> ok mglocker@
>

Thanks, commited.

> When reviewing the diff I've noticed that we might could do some small
> improvements regarding the structure sizes in a second step:
> 
> - We probably should define an union structure within a packed structure
>   also with '__packed', like other drivers are doing it.  I'm not sure
>   depending on the compiler/architecture whether otherwise an union
>   structure could be interpreted as non-packed.  Maybe other developers
>   can comment on their opinion about that.
> 
> - The constant integers used in uvideo_vs_parse_desc_format() for the
>   format structure sizes should be all replaced by defines in uvideo.h:
> 
> 	desc->bLength == 6
> 	desc->bLength == 11
> 	desc->bLength == 27
> 	desc->bLength == 52
>

And we also ignores the return code of uvideo_vs_parse_desc_format_XXX.

I plan to send one more diff to bring the last piece of support my Elgato
device, and I sugggest to wait couple of weeks before we start to house
keeping to allow folks to report if it broke something.

-- 
wbr, Kirill