On 2025-08-05 13:30 +02, Alexander Bluhm <bluhm@openbsd.org> wrote:
> On Sun, Aug 03, 2025 at 08:04:40PM +0200, Florian Obser wrote:
>> It's probably best to first commit userland and then a week later or so
>> the kernel bits. I've successfully built a release with the full diff.
>
> Please commit slaacd well before removing kernel support.  Especially
> removing the pledge exception in kernel before new daemons have
> been distibuted may hurt people.
>
>> OK?
>
> If the key is too short parse_hex_string() should fill dst with \0
> until dstlen.  Or read_soiikey() should insist that parse_hex_string()
> returns sizeof(soiikey).

I've added a memset to parse_hex_string(). In slaacd it does not matter,
parse_hex_string() operates on a global which is initialized to zero and
the function is only called once.

>
> read_soiikey() leaks the file descriptor in the successful case.

good catch, fixed.

>
> Otherwise OK bluhm@
>

-- 
In my defence, I have been left unsupervised.