Index | Thread | Search

From:
Alexandr Nedvedicky <sashan@fastmail.net>
Subject:
Re: use proper rtable limit in sppp code
To:
tech@openbsd.org
Date:
Tue, 19 Aug 2025 12:27:08 +0200

Download raw body.

Thread
Hello,

On Tue, Aug 19, 2025 at 11:02:37AM +0200, Claudio Jeker wrote:
> I want to remove most use of RT_TABLEID_MAX (or actually make it a pure
> userland thing and allowing it to be much larger).
> 
> sppp(4) still uses it in a for loop where most other callers use
> rtmap_limit. So this diff does the same as code in route.c.

    there is yet another one use of RT_TABLEID_MAX in
    for loop like we see here in sppp_update_gw() here
    in  mrt_sysctl_mfc() in ip_mroute.c, shall we take care of it too?

    I'm not sure about the other occurrences of RT_TABLEID_MAX we tree,
    but those are perhaps out of scope at least for now.

thanks and
regards
sashan