Index | Thread | Search

From:
Mark Kettenis <mark.kettenis@xs4all.nl>
Subject:
Re: another yubikey diff
To:
"Theo de Raadt" <deraadt@openbsd.org>
Cc:
miod@online.fr, tech@openbsd.org
Date:
Fri, 22 Aug 2025 16:39:12 +0200

Download raw body.

Thread
> From: "Theo de Raadt" <deraadt@openbsd.org>
> Date: Fri, 22 Aug 2025 08:31:19 -0600
> 
> Why not invert this with a "donotconnect" variable, then your diff
> shrinks significantly.

Not really; the struct wkbddev_attach_args is typically allocated on
the stack, without an explicit memset, so the new member must be set.