Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: imsg-buffer.c, remove unsused variable
To:
tech@openbsd.org
Date:
Mon, 25 Aug 2025 10:17:16 +0200

Download raw body.

Thread
On Mon, Aug 25, 2025 at 10:12:22AM +0200, Claudio Jeker wrote:
> Some compilers found and complained about this unused variable.

ok

Maybe libutil should use some compiler flags like -Wall and -Wundef to
catch such cosmetic issues and possibly more serious ones. It's not the
first time that this happens.

> 
> -- 
> :wq Claudio
> 
> Index: imsg-buffer.c
> ===================================================================
> RCS file: /cvs/src/lib/libutil/imsg-buffer.c,v
> diff -u -p -r1.35 imsg-buffer.c
> --- imsg-buffer.c	4 Jun 2025 09:06:56 -0000	1.35
> +++ imsg-buffer.c	23 Aug 2025 21:33:47 -0000
> @@ -686,8 +686,6 @@ msgbuf_queuelen(struct msgbuf *msgbuf)
>  void
>  msgbuf_clear(struct msgbuf *msgbuf)
>  {
> -	struct ibuf	*buf;
> -
>  	/* write side */
>  	ibufq_flush(&msgbuf->bufs);
>  
>