Index | Thread | Search

From:
Jeremie Courreges-Anglas <jca@wxcvbn.org>
Subject:
Re: fuse: remove ioctl from /dev/fuse0
To:
Helg <helg-openbsd@gmx.de>
Cc:
tech@openbsd.org
Date:
Mon, 8 Sep 2025 13:59:20 +0200

Download raw body.

Thread
On Fri, Sep 05, 2025 at 09:00:15PM +0200, Helg wrote:
> On Sun, Sep 07, 2025 at 07:38:28PM +0200, Jeremie Courreges-Anglas wrote:
> > On Sun, Sep 07, 2025 at 06:45:35PM +0200, Helg wrote:
> > > Cleanup the kernel fuse device code to remove support for ioctl. This
> > > is no longer needed since an fbuf is now read or written in one go,
> > > rather than a combination of read(2) or write(2) and ioctl(2) to read
> > > or write the buffer used by the vfs syscalls read, write, readlink and
> > > readdir.
> > > 
> > > OK?
> > 
> > Makes sense, but is this code holding you back from further
> > improvements?  Or can you keep it in for some time, just for
> > compatibility between a new kernel and an old libfuse?
> > 
> > -- 
> > jca
> 
> The kernel is no longer compatible with an old libfuse because it now
> expects the fusebuf and data to be read and written at the same time.

I suspected so, thanks for confirming.

> It's not holding me back so could stay longer, but it's essentially dead
> code now. 

Sure, ok jca@ to drop it.

-- 
jca