Index | Thread | Search

From:
Thorsten Blum <thorsten.blum@toblux.com>
Subject:
Re: kern_malloc: Simplify if/else in BUCKETINDX()
To:
A Tammy <openbsd.tech@aisha.cc>
Cc:
tech@openbsd.org
Date:
Sat, 11 Oct 2025 21:24:25 +0200

Download raw body.

Thread
On 6. Oct 2024, at 23:12, A Tammy wrote:
> On 10/6/24 3:29 PM, Thorsten Blum wrote:
>> Index: kern/kern_malloc.c
>> ===================================================================
>> RCS file: /cvs/src/sys/kern/kern_malloc.c,v
>> retrieving revision 1.152
>> diff -u -p -r1.152 kern_malloc.c
>> --- kern/kern_malloc.c	26 Jun 2024 01:40:49 -0000	1.152
>> +++ kern/kern_malloc.c	6 Oct 2024 18:50:42 -0000
>> @@ -68,9 +68,7 @@ BUCKETINDX(size_t sz)
>> 			b += d;
>> 		d >>= 1;
>> 	}
>> -	if (sz <= (1 << b))
>> -		b += 0;
>> -	else
>> +	if (sz > (1 << b))
>> 		b += 1;
>> 	return b;
>> }
>> 
> 
> OK aisha

This was never applied, was it?