Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: bgpctl: fix arguments to ibuf_from_ibuf call
To:
tech@openbsd.org
Date:
Tue, 4 Nov 2025 11:57:25 +0100

Download raw body.

Thread
On Tue, Nov 04, 2025 at 11:54:05AM +0100, Claudio Jeker wrote:
> The arguments in the ibuf_form_ibuf call in show_mrt_update() are
> reversed. The first argument is the target, the second is the source.
> 
> Fix for CID 492345

ok tb

> -- 
> :wq Claudio
> 
> Index: bgpctl.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/bgpctl/bgpctl.c,v
> diff -u -p -r1.317 bgpctl.c
> --- bgpctl.c	10 Mar 2025 14:08:25 -0000	1.317
> +++ bgpctl.c	3 Nov 2025 22:01:57 -0000
> @@ -1690,7 +1690,7 @@ show_mrt_update(struct ibuf *b, int reqf
>  		uint16_t attrlen;
>  		uint8_t flags;
>  
> -		ibuf_from_ibuf(&abuf, &attrbuf);
> +		ibuf_from_ibuf(&attrbuf, &abuf);
>  		if (ibuf_get_n8(&attrbuf, &flags) == -1 ||
>  		    ibuf_skip(&attrbuf, 1) == -1)
>  			goto trunc;
>