> On 10 Nov 2025, at 19:56, hshoexer <hshoexer@yerbouti.franken.de> wrote:
> 
> On Sun, Nov 09, 2025 at 09:54:23AM +1000, David Gwynne wrote:
>> ...
>> so ok on this?
> 
> I think the diff is missing a change for amd64/conf/files.amd64:
> To actually compile don't we need device cpu to depend on xcall?
> Like this:

i think whatever code depends on it should cause it to get compiled.

> 
> diff --git a/sys/arch/amd64/conf/files.amd64 b/sys/arch/amd64/conf/files.amd64
> index 630de36a01d..38d5796f650 100644
> --- a/sys/arch/amd64/conf/files.amd64
> +++ b/sys/arch/amd64/conf/files.amd64
> @@ -95,7 +95,7 @@ file arch/amd64/amd64/mpbios.c mpbios needs-flag
> file arch/amd64/amd64/mpbios_intr_fixup.c mpbios & pci
> 
> define cpu {[apid = -1]}
> -device cpu
> +device cpu: xcall
> attach cpu at mainbus
> file arch/amd64/amd64/cpu.c cpu
> 
>