On Tue, 11 Nov 2025 19:12:14 +0100,
Christoph Liebender <christoph@liebender.dev> wrote:
> 
> I've tested this in front of nginx that is configured via
> 
> listen 8443 ssl proxy_protocol;
> 
> and it works as expected with both PROXY versions. Below is a patch with
> some formatting nits and #defined magic numbers.
> 
> comments, ok?

Not (yet) tested, but read. Thoughts:

1. style(9) states that all code should fit in 80 columns. It's not true for
   this diff.

2. Not sure that proxy.c is good naming. It a bit missleading. Probably
   proxy protocol or something like that is cleaner.

3. bzero instead memset(0), probably, cleaner.

4. optproxyproto in parse.y looks like is allowing to not specify the
   version, that is a bit wired and lead to undefined logic, or I missed
   something?

5. Not sure why have you limited proxy protocol only for TCP connection. It
   can be used for anything, am I wrong?

-- 
wbr, Kirill