On Thu, Nov 20, 2025 at 02:35:32PM +0100, Theo Buehler wrote:
> On Thu, Nov 20, 2025 at 01:57:28PM +0100, Claudio Jeker wrote:
> > Split up the PREFIX flags, split the name space and use PREFIX_ADJOUT
> > for those that only affect that struct.
> > In the process retire PREFIX_FLAG_ADJOUT.
> 
> Reads fine. One question below which you can fix (or not) before commit.
> 
> ok tb
 
Thanks see below.

> > @@ -257,12 +257,11 @@ prefix_adjout_update(struct prefix_adjou
> >  			/* nothing changed */
> >  			p->validation_state = state->vstate;
> >  			p->lastchange = getmonotime();
> > -			p->flags &= ~PREFIX_FLAG_STALE;
> 
> Maybe I'm missing something, but should this not do
> 
> 			p->flags &= ~PREFIX_ADJOUT_FLAG_STALE;
> 
 
I think you're right. I will commit this with that line added.
PREFIX_ADJOUT_FLAG_STALE will die another day :)

-- 
:wq Claudio