Index | Thread | Search

From:
Kirill A. Korinsky <kirill@korins.ky>
Subject:
Re: httpd: add missing GZIP_STATIC flag to SRVFLAG_BITS macro
To:
Rafael Sadowski <rafael@sizeofvoid.org>
Cc:
tech@openbsd.org
Date:
Thu, 27 Nov 2025 11:10:57 +0100

Download raw body.

Thread
On Thu, 27 Nov 2025 08:19:57 +0100,
Rafael Sadowski <rafael@sizeofvoid.org> wrote:
> 
> GZIP_STATIC flag at position \33 was missing from the debug string.
> 
> Also correct the truncated PATH_REWRITE/NO_PATH_REWRITE flag names.
> The PATH_REWRITE and NO_PATH_REWRITE flag names were truncated to
> PATH and NO_PATH in the SRVFLAG_BITS string definition. I think
> this solution is more consistent.
> 
> I know it's two things at once, but I don't think they hurt
> together.
> 
> OK?
>

OK kirill@

> diff --git a/usr.sbin/httpd/httpd.h b/usr.sbin/httpd/httpd.h
> index 0289e1fbec1..9b143f37844 100644
> --- a/usr.sbin/httpd/httpd.h
> +++ b/usr.sbin/httpd/httpd.h
> @@ -397,8 +397,9 @@ SPLAY_HEAD(client_tree, client);
>  	"\05ROOT\06LOCATION\07FCGI\10NO_FCGI\11LOG\12NO_LOG\13ERRDOCS"	\
>  	"\14SYSLOG\15NO_SYSLOG\16TLS\17ACCESS_LOG\20ERROR_LOG"		\
>  	"\21AUTH\22NO_AUTH\23BLOCK\24NO_BLOCK\25LOCATION_MATCH"		\
> -	"\26SERVER_MATCH\27SERVER_HSTS\30DEFAULT_TYPE\31PATH\32NO_PATH" \
> -	"\37LOCATION_FOUND\40LOCATION_NOT_FOUND"
> +	"\26SERVER_MATCH\27SERVER_HSTS\30DEFAULT_TYPE\31PATH_REWRITE"	\
> +	"\32NO_PATH_REWRITE\33GZIP_STATIC\37LOCATION_FOUND"		\
> +	"\40LOCATION_NOT_FOUND"
>  
>  #define TCPFLAG_NODELAY		0x01
>  #define TCPFLAG_NNODELAY	0x02

-- 
wbr, Kirill