Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: bgpd: cleanup adjout_prefix dump upcalls
To:
tech@openbsd.org
Date:
Fri, 12 Dec 2025 15:39:39 +0100

Download raw body.

Thread
On Fri, Dec 12, 2025 at 01:27:00PM +0100, Claudio Jeker wrote:
> This step prepares for the next round of Adj-RIB-Out rework.
> The adjout_prefix_dump upcalls gain a few extra arguments.
> Both the peer and the pt_entry are now passed to the upcall since these
> values will be removed from struct adjout_prefix.
> 
> While the change is simple it results in a lot of churn inside the rde rib
> control message handler. Since the pte needs to be passed to the callbacks
> the code doing the quick lookups got changed to use pt_lookup and friends
> and use adjout_prefix_first() and adjout_prefix_next() to talk the
> adj-rib-out. With this adjout_prefix_lookup() and adjout_prefix_match()
> become unused.
> 
> In up_generate_default() the adjout_prefix_lookup() can be removed and
> replaced with a adjout_prefix_first() call after the pte is fetched.

ok tb