Index | Thread | Search

From:
Crystal Kolipe <kolipe.c@exoticsilicon.com>
Subject:
Re: httpd: fix scan-build dead stores findings
To:
Rafael Sadowski <rafael@sizeofvoid.org>
Cc:
tech@openbsd.org
Date:
Sun, 28 Dec 2025 10:10:07 +0000

Download raw body.

Thread
On Sun, Dec 28, 2025 at 06:55:28AM +0100, Rafael Sadowski wrote:
> Hi,
> 
> scan-build flagged a few dead stores in httpd:
> 
> - config.c:636 ??? s incremented but never used after
> - httpd.c:533 ??? q assigned but immediately overwritten in the loop
> - server.c:891 ??? inrd/inwr assigned, then reassigned, never actually needed
> - server_fcgi.c:678,690 ??? kv result unused
> 
> OK?

Looks good to me, from reading the code these are indeed dead stores and the
code works fine after removal.