Index | Thread | Search

From:
Jonathan Gray <jsg@jsg.id.au>
Subject:
Re: pci(4): Add missing Xr to radeonfb and fix/break width.
To:
Jesper Wallin <jesper@ifconfig.se>
Cc:
tech@openbsd.org
Date:
Wed, 31 Dec 2025 10:22:58 +1100

Download raw body.

Thread
On Tue, Dec 30, 2025 at 02:49:13PM +0100, Jesper Wallin wrote:
> In pci(4), under Display adapters, radeonfb(4) is missing a Xr.
> 
> By adding it though, it adds an ugly linebreak due to too compact width.
> Increasing the width of the first column fix this, but it makes the
> whole segment unaligned.  I still believe it's the right approach, as
> it's already the case for "IDE disk controllers" further up.
> 
> I can't decide what's best though, -width 11n or -width "radeonfb(4)".

Well spotted.  Committed with -width 11n.  No preference is mentioned
in mdoc(7) for how to specify the width.

> 
> 
> Jesper Wallin
> 
> 
> Index: pci.4
> ===================================================================
> RCS file: /cvs/src/share/man/man4/pci.4,v
> diff -u -p -r1.413 pci.4
> --- pci.4	19 Sep 2025 00:42:06 -0000	1.413
> +++ pci.4	30 Dec 2025 13:41:36 -0000
> @@ -366,7 +366,7 @@ PCI
>  communications card driver
>  .El
>  .Ss Display adapters
> -.Bl -tag -width 10n -offset ind -compact
> +.Bl -tag -width 11n -offset ind -compact
>  .It Xr astfb 4
>  Aspeed BMC frame buffer
>  .It Xr gfxp 4
> @@ -375,7 +375,7 @@ accelerated color frame buffer
>  inextricable frame buffer
>  .It Xr machfb 4
>  accelerated color frame buffer
> -.It radeonfb 4
> +.It Xr radeonfb 4
>  accelerated color frame buffer
>  .It Xr raptor 4
>  accelerated color frame buffer
> 
>