Index | Thread | Search

From:
Kirill A. Korinsky <kirill@korins.ky>
Subject:
Re: smtpd: Don't allow max-rcpt lower 100
To:
Martijn van Duren <openbsd+tech@list.imperialat.at>
Cc:
tech@openbsd.org
Date:
Fri, 02 Jan 2026 17:42:23 +0100

Download raw body.

Thread
On Fri, 02 Jan 2026 17:05:34 +0100,
Martijn van Duren <openbsd+tech@list.imperialat.at> wrote:
> 
> According to RFC5321 section 4.5.3.1.8 we aren't allowed to have a
> max-rcpt lower than 100 (MUST). This diff prevents admins from setting
> max-rcpt to anything lower than 100.
> 
> OK?
>

Not sure that it right, but maybe add reference to RFC section here as a
reason why we enforce that magic constatn?

> martijn@
> 
> diff b9146a17035f22954d6f1be04af1b32218d3b317 85f1ad07b22990cf52e6c13160cc696bf2948fa6
> commit - b9146a17035f22954d6f1be04af1b32218d3b317
> commit + 85f1ad07b22990cf52e6c13160cc696bf2948fa6
> blob - b4cf1f21ddb02dce7a4911285e33eebfcf517067
> blob + dda128bfd70c096b3290a2e0fc1dc84ca6cdc53d
> --- usr.sbin/smtpd/parse.y
> +++ usr.sbin/smtpd/parse.y
> @@ -2037,6 +2037,11 @@ limits_smtp	: opt_limit_smtp limits_smtp
>  
>  opt_limit_smtp : STRING NUMBER {
>  			if (!strcmp($1, "max-rcpt")) {
> +				if ($2 < 100) {
> +					yyerror("max-rcpt can't be lower than 100");
> +					free($1);
> +					YYERROR;
> +				}
>  				conf->sc_session_max_rcpt = $2;
>  			}
>  			else if (!strcmp($1, "max-mails")) {
> 

-- 
wbr, Kirill