Index | Thread | Search

From:
Vitaliy Makkoveev <mvs@openbsd.org>
Subject:
bse: drop ifp->if_flags and ifq_is_oactive() checks
To:
tech@openbsd.org, kettenis@openbsd.org
Date:
Fri, 2 Jan 2026 14:57:31 +0300

Download raw body.

Thread
  • Vitaliy Makkoveev:

    bse: drop ifp->if_flags and ifq_is_oactive() checks

Our caller, the interface queues layer, already did them.

Index: sys/dev/ic/bcmgenet.c
===================================================================
RCS file: /cvs/src/sys/dev/ic/bcmgenet.c,v
retrieving revision 1.8
diff -u -p -r1.8 bcmgenet.c
--- sys/dev/ic/bcmgenet.c	5 Nov 2024 18:58:59 -0000	1.8
+++ sys/dev/ic/bcmgenet.c	2 Jan 2026 18:59:12 -0000
@@ -793,11 +793,6 @@ genet_start(struct ifnet *ifp)
 	const int qid = GENET_DMA_DEFAULT_QUEUE;
 	int nsegs, index, cnt;
 
-	if ((ifp->if_flags & IFF_RUNNING) == 0)
-		return;
-	if (ifq_is_oactive(&ifp->if_snd))
-		return;
-
 	index = sc->sc_tx.pidx & (TX_DESC_COUNT - 1);
 	cnt = 0;