Index | Thread | Search

From:
Alexander Farber <alexander.farber@gmail.com>
Subject:
keynote verify: remove dead options from getopt
To:
tech@openbsd.org
Date:
Tue, 6 Jan 2026 16:11:46 +0100

Download raw body.

Thread
  • Alexander Farber:

    keynote verify: remove dead options from getopt

The options q, i, s, t in the getopt string have no case handlers and
fall through to the default case which shows usage and exits. Remove
them from the getopt string.

ok?

Index: keynote-verify.c
===================================================================
RCS file: /cvs/src/lib/libkeynote/keynote-verify.c,v
retrieving revision 1.20
diff -u -r1.20 keynote-verify.c
--- keynote-verify.c 24 Oct 2021 21:24:20 -0000 1.20
+++ keynote-verify.c 6 Jan 2026 14:58:51 -0000
@@ -91,7 +91,7 @@
  exit(keynote_errno);
     }

-    while ((ch = getopt(argc, argv, "hqistl:e:k:r:")) != -1)
+    while ((ch = getopt(argc, argv, "hl:e:k:r:")) != -1)
     {
  switch (ch)
  {