Index | Thread | Search

From:
Marc Espie <marc.espie.openbsd@gmail.com>
Subject:
patch: trivial thinko in kernel code
To:
tech@openbsd.org
Date:
Sat, 21 Feb 2026 14:55:52 +0100

Download raw body.

Thread
  • Marc Espie:

    patch: trivial thinko in kernel code

I don't see any valid reason to declare the same global twice, unless
I'm missing something.

There probably were two actual variables at some point + some search 
and replace, but I haven't gone through the mailing-list archives
to figure that out.



Index: syscall_mi.h
===================================================================
RCS file: /build/data/openbsd/cvs/src/sys/sys/syscall_mi.h,v
diff -u -p -r1.37 syscall_mi.h
--- syscall_mi.h	27 Dec 2024 11:57:16 -0000	1.37
+++ syscall_mi.h	21 Feb 2026 12:55:03 -0000
@@ -54,7 +54,7 @@
 static inline int
 pin_check(struct proc *p, register_t code)
 {
-	extern char sigcodecall[], sigcoderet[], sigcodecall[];
+	extern char sigcodecall[], sigcoderet[];
 	struct pinsyscall *pin = NULL, *ppin, *plibcpin;
 	struct process *pr = p->p_p;
 	vaddr_t addr;