Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
Re: relayd: fix memory leak in rsae_send_imsg
To:
Rafael Sadowski <rafael@sizeofvoid.org>
Cc:
tech@openbsd.org
Date:
Mon, 23 Feb 2026 22:36:39 +0100

Download raw body.

Thread
On Mon, Feb 23, 2026 at 09:33:42PM +0100, Rafael Sadowski wrote:
> Looks like we're leaking memory in rsae_send_imsg. If the cookie doesn't
> match, we bail with a continue and totally forget to free the imsg.

Indeed. OK claudio@
 
> diff --git a/usr.sbin/relayd/ca.c b/usr.sbin/relayd/ca.c
> index e54259c5971..f44a9d2a556 100644
> --- a/usr.sbin/relayd/ca.c
> +++ b/usr.sbin/relayd/ca.c
> @@ -380,6 +380,7 @@ rsae_send_imsg(int flen, const u_char *from, u_char *to, RSA *rsa,
>  				    "%s: priv%s obsolete keyop #%x", __func__,
>  				    cmd == IMSG_CA_PRIVENC ? "enc" : "dec",
>  				    cko.cko_cookie);
> +				imsg_free(&imsg);
>  				continue;
>  			}
>  
> 

-- 
:wq Claudio