Index | Thread | Search

From:
Jonathan Matthew <jonathan@d14n.org>
Subject:
Re: ixl 64 bit dma
To:
Alexander Bluhm <bluhm@openbsd.org>
Cc:
tech@openbsd.org
Date:
Thu, 26 Feb 2026 09:31:56 +1000

Download raw body.

Thread
On Wed, Feb 25, 2026 at 11:12:55PM +0100, Alexander Bluhm wrote:
> Hi,
> 
> In ixl(4) only a single bus_dmamem_alloc() is missing BUS_DMA_64BIT.
> 
> ok?

ok jmatthew@

> 
> bluhm
> 
> Index: dev/pci/if_ixl.c
> ===================================================================
> RCS file: /data/mirror/openbsd/cvs/src/sys/dev/pci/if_ixl.c,v
> diff -u -p -r1.115 if_ixl.c
> --- dev/pci/if_ixl.c	19 Feb 2026 10:15:36 -0000	1.115
> +++ dev/pci/if_ixl.c	25 Feb 2026 22:11:04 -0000
> @@ -5183,7 +5183,7 @@ ixl_dmamem_alloc(struct ixl_softc *sc, s
>  		return (1);
>  	if (bus_dmamem_alloc(sc->sc_dmat, ixm->ixm_size,
>  	    align, 0, &ixm->ixm_seg, 1, &ixm->ixm_nsegs,
> -	    BUS_DMA_WAITOK | BUS_DMA_ZERO) != 0)
> +	    BUS_DMA_WAITOK | BUS_DMA_ZERO | BUS_DMA_64BIT) != 0)
>  		goto destroy;
>  	if (bus_dmamem_map(sc->sc_dmat, &ixm->ixm_seg, ixm->ixm_nsegs,
>  	    ixm->ixm_size, &ixm->ixm_kva, BUS_DMA_WAITOK) != 0)
>