Index | Thread | Search

From:
Jonathan Matthew <jonathan@d14n.org>
Subject:
Re: aq 64-bit dma
To:
Brent Cook <busterb@gmail.com>
Cc:
tech@openbsd.org
Date:
Thu, 12 Mar 2026 15:32:53 +1000

Download raw body.

Thread
  • Brent Cook:

    aq 64-bit dma

    • Jonathan Matthew:

      aq 64-bit dma

    • Mark Kettenis:

      aq 64-bit dma

On Wed, Mar 11, 2026 at 11:06:39PM -0500, Brent Cook wrote:
> This was the only bus_dmamem call missing BUS_DMA_64BIT in aq(4).
> 
> Tested on an AQC107S without any issues. I think Brad Smith posted this
> in a mixed diff earlier too.
> 
> ok?

ok jmatthew@

> 
> Index: if_aq_pci.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/pci/if_aq_pci.c,v
> diff -u -p -u -p -r1.34 if_aq_pci.c
> --- if_aq_pci.c	15 Jan 2026 06:41:21 -0000	1.34
> +++ if_aq_pci.c	12 Mar 2026 03:58:19 -0000
> @@ -4043,7 +4043,7 @@ aq_dmamem_alloc(struct aq_softc *sc, str
>  		return (1);
>  	if (bus_dmamem_alloc(sc->sc_dmat, aqm->aqm_size,
>  	    align, 0, &aqm->aqm_seg, 1, &aqm->aqm_nsegs,
> -	    BUS_DMA_WAITOK | BUS_DMA_ZERO) != 0)
> +	    BUS_DMA_WAITOK | BUS_DMA_ZERO | BUS_DMA_64BIT) != 0)
>  		goto destroy;
>  	if (bus_dmamem_map(sc->sc_dmat, &aqm->aqm_seg, aqm->aqm_nsegs,
>  	    aqm->aqm_size, &aqm->aqm_kva,
>