Hi, 

On 3/11/26 08:17, Hrvoje Popovski wrote:
> Hi,
> 
> before this diff in dmesg it was
> ixv0 at pci4 dev 0 function 0 "Intel 82599" rev 0x01, msix, 2 queues
> 
> after diff
> ixv0 at pci4 dev 0 function 0 "Intel 82599 VF" rev 0x01, msix, 2 queues
> 
> while mcx vf and iavf are
> mcx0 at pci19 dev 0 function 0 "Mellanox ConnectX-4 Lx VF" rev 0x00: FW
> 14.32.2104, msix, 8 queues, address 00:0c:29:4f:8c:3b
> 
> iavf0 at pci27 dev 0 function 0 "Intel XL710/X710 VF" rev 0x01, VF
> version 1.1, VF 0 VSI 26, msix, 4 queues, address 00:0c:29:4f:8c:3c
> 
> it would be nice to have mac addess in dmesg for ixv?

I feel it's OK to print "82599 VF" in the dmesg.
And also printing the MAC address in the ixv probe message is easy. 
The `pcidevs.h` and `pcidevs_data.h` are generated from the `pcidevs` file.
These two header files don't need to be reviewed.
See the `Makefile` in sys/dev/pci directory for details.

The following diff merges the printing '82599 VF' and the MAC address.

OK?

diff --git a/sys/dev/pci/if_ixv.c b/sys/dev/pci/if_ixv.c
index 0dd860ef022..1b3d9e5dd49 100644
--- a/sys/dev/pci/if_ixv.c
+++ b/sys/dev/pci/if_ixv.c
@@ -1313,8 +1313,8 @@ ixv_allocate_msix(struct ix_softc *sc)
 		pci_conf_write(pa->pa_pc, pa->pa_tag, off, reg | PCI_MSIX_MC_MSIXE);
 	}
 
-	printf(", %s, %d queue%s\n", pci_intr_string(pa->pa_pc, ih),
-	    i, (i > 1) ? "s" : "");
+	printf(", %s, %d queue%s, address %s\n", pci_intr_string(pa->pa_pc, ih),
+	    i, (i > 1) ? "s" : "", ether_sprintf(sc->hw.mac.addr));
 
 	return (0);
 
diff --git a/sys/dev/pci/pcidevs b/sys/dev/pci/pcidevs
index 1bd33a74644..af836c3f51b 100644
--- a/sys/dev/pci/pcidevs
+++ b/sys/dev/pci/pcidevs
@@ -3968,7 +3968,7 @@ product INTEL 82545GM_COPPER	0x1026	82545GM
 product INTEL 82545GM_FIBER	0x1027	82545GM
 product INTEL 82545GM_SERDES	0x1028	82545GM
 product INTEL PRO_100		0x1029	PRO/100
-product INTEL 82559		0x1030	82559
+product INTEL 82559		0x1030	82559 VF
 product INTEL PRO_100_VE_0	0x1031	PRO/100 VE
 product INTEL PRO_100_VE_1	0x1032	PRO/100 VE
 product INTEL PRO_100_VM_0	0x1033	PRO/100 VM


-- 
Yuichiro NAITO (naito.yuichro@gmail.com)