Index | Thread | Search

From:
Crystal Kolipe <kolipe.c@exoticsilicon.com>
Subject:
Re: typo fix in uvm_object.h
To:
Benjamin Lee McQueen <mcq@disroot.org>
Cc:
tech@openbsd.org
Date:
Mon, 16 Mar 2026 23:38:22 +0000

Download raw body.

Thread
On Mon, Mar 16, 2026 at 05:02:52PM -0600, Benjamin Lee McQueen wrote:
> > From kolipe.c@exoticsilicon.com Mon Mar 16 17:40:31 2026
> > Why not fix the spacing and missing capital letters at the beginning of
> > sentences at the same time whilst we're changing this comment?
> good idea, and i'm willing to send an updated diff, but across UVM, a
> similar style of writing is still there - dating back to (a long time ago)
> 
> it isn't the only style of writing found across UVM, but it would
> introduce inconsistency which likely doesn't affect readability either.
> unless a whole rewrite of a comment style across a subsystem _really_
> impacts the overall readibility, it shouldn't be changed. 

Well the 'three spaces followed by a lower case letter after full stop' style
is not used much outside uvm, or indeed at all in the kernel source:

# grep -R '\.   [a-z]' /usr/src/sys | wc -l
214

But either way OK for the detected -> detect change.