Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: vi(1), removing unused variables
To:
Walter Alejandro Iglesias <wai@roquesor.com>
Cc:
tech@openbsd.org
Date:
Mon, 20 Apr 2026 10:47:45 +0200

Download raw body.

Thread
On Mon, Apr 20, 2026 at 09:33:47AM +0200, Walter Alejandro Iglesias wrote:
> I'm tired of seeing those warning messages each time I compile.

Committed, thanks.

I changed one thing:

> -	TAILQ_FOREACH(tp, &tiq, q) {
> +	TAILQ_FOREACH(tp, &tiq, q)
>  		if (db_append(sp, 1, lno++, tp->lb, tp->len))
>  			return (1);
> -		cnt++;
> -	}

I left the braces here since I think removing braces to save a line is
a bad trade off in general and in this case style(9) explicitly permits
and suggests it.