Download raw body.
doas: make unveilcommands() static
For what benefit? Explain it.
>From owner-tech+M108152@openbsd.org Sun May 3 08:00:24 2026
>Delivered-To: deraadt@cvs.openbsd.org
>DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=selector1; bh=LsvFxPwrtW
> kGC9BzBr45PryBx+H7+z5JVE6O50w5RRA=; h=list-unsubscribe:list-subscribe:
> list-post:list-owner:list-id:list-help:subject:to:from:date;
> d=openbsd.org; b=lr19+8hQ0zL6ZjgqsofSyxP9MCbMwYrtRJe1LQ66tqIcdooF2YLVJ
> tSzjJyRbLqI5KVetwPl3fi17akWVi2FU2ydxrLXTgCP5SqObgj9qgjMj7HG+xAXzDjSAfb
> RVZOrleb6PBqtwlduC5Y2WwK+SVyyigDGY3dqPRN1DeUpV80TOwGvSGCBg3QXZY0VVoZ0y
> iAas4j99FxE784p9MQfQmaYKajK/XVH2Z+L7xp0c7Ye9vVmQh6DtX6mpiJ8ttfJPynemCX
> WbonRJjGqhkzKgR3usJ9krnBVLsgmIUrYkDMktaoiaVqCDp0VIVb+RUjSOGejhJwKGbfLl
> UFu0JyURQ==
>DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
> d=gmail.com; s=20251104; t=1777816723; x=1778421523; darn=openbsd.org;
> h=content-disposition:mime-version:message-id:subject:to:from:date
> :from:to:cc:subject:date:message-id:reply-to;
> bh=TxcTAhS+bUgGHLRkwe3OwGSG2coPFuyDFYv11/51sus=;
> b=SOjuOvNXgxNQ2JHfaWg3USHlh2zF6sN1PRH0cZ/FdvckwDZyZvVRE6IcFFiJ3eEjhv
> /Jnd4VOO4l0B9AHTJqVxFU99DGybyeUBYt4Lj+3HlwjuHQB5aVvS2RSLWxFgYec2ddsl
> /QETYz07ltq0rWR54Moi4KNlWjy625Cki0+FBx5T+a+UIBDc5yfoBrgmXYj9xmP/NxmZ
> Qv5J/bZ0/JL6te02dx5BHI0RZbsXywVg/A24CXbbY0fuyyxgGlv2huspWCsCFMp2lfAq
> U4SlAGPaKDFWhBh+2hrX/yg67jPrATbBTYMIxF5hXjM1rZ8hjXP7D/nz6RLTc0ueLiLw
> BN4g==
>X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
> d=1e100.net; s=20251104; t=1777816723; x=1778421523;
> h=content-disposition:mime-version:message-id:subject:to:from:date
> :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id
> :reply-to;
> bh=TxcTAhS+bUgGHLRkwe3OwGSG2coPFuyDFYv11/51sus=;
> b=IGYzW+i3bhczHTCADLFNUpL9l44u4ATsfyVaokp80Y+YX7kuYIxKt2ABcQsLEgESEa
> 4J8oDkz2hnUkyZnxod1QZQ5/l7LgOI5MeFOt2WSnwsAx77XWMaq9cnqCn4h24EwoPY4B
> bCq0bs6XZd3GQ1Z0RxrBsKwdsrYzqOijh8tyO0dQ8tbrAmQm9w2RqhVOavt8nGtV4MrP
> 6h/HLImbNjDMeY6UZ8cmdsnlM9aBGSg54FSexDl+q4MNTZd14gk8pYpqY1L2cVV+TkeS
> RVmgbpK1Y5VWL37DkvY4g7bOXbJHvsPbvpzz73Q10RvJjIeZAvYJCD7IOie2bIkxt9rc
> 1y0w==
>X-Gm-Message-State: AOJu0YzzLfdyo2ApWJg5bIJAqxhEkpDFs288j7KlkuHLeInjntr2Zrrx
> CWiZo0ON8ltdHpvuBQP5lK/Z+05ONIUPmpj4ZDE4CG6fCPtpVxbPGnLGDK0qJA==
>X-Gm-Gg: AeBDieuUfgyJtRHoguiPUDg4Eo3v22w+TvuSafdG+I+Hv8FsACYbEeDUJb9Z6IvDmyQ
> f1sI1BAWwsec4udUreFJTspBoHTv+4bkACCVB1ExUxLBRQIU/8cJnD3zmBC/UWN3/BGU9JEonyR
> nCv7xvAdAug39zfd3yt6FmsSjkCVvUE/ozBWbUaDFZz2GJniZffbrVc7WGNudj9BcjXobvUlCWD
> 27nJOVX06Va+piOuRKR2UHhy2ZQ5suc8q1u+VzBb9PC5fqWjsIBYiyfUn5e3V9krg/w/P8lkV4O
> 189UqUd8dT4zwt22BcaZRMs4u7D/cl3bT7d/lm30oLS7LmNMdZ5DOQ1X6wgX8EvA2TZHUDP2Hs1
> LWT3ySa4bycURHvySv22whMNs/HFS2XhMcT4ZLgUcuQsYiBr01YvYsmvlzfk4tcT4buhyNOBxhx
> BHLMuVMWIpZyx3eqgM8/IwjftEM8uswLg21PsJFtDucIuGI3H/IUXZwlsOhq48u2pCSLI=
>X-Received: by 2002:a17:90b:1cc5:b0:362:e51c:fd9c with SMTP id 98e67ed59e1d1-3650ceced10mr5592559a91.17.1777816723430;
> Sun, 03 May 2026 06:58:43 -0700 (PDT)
>Date: Sun, 3 May 2026 22:58:41 +0900
>From: Takumi Matsuura <tm99hjkl@gmail.com>
>To: tech@openbsd.org
>Subject: doas: make unveilcommands() static
>MIME-Version: 1.0
>Content-Type: text/plain; charset=us-ascii
>Content-Disposition: inline
>List-Help: <mailto:majordomo@openbsd.org?body=help>
>List-ID: <tech.openbsd.org>
>List-Owner: <mailto:owner-tech@openbsd.org>
>List-Post: <mailto:tech@openbsd.org>
>List-Subscribe: <mailto:majordomo@openbsd.org?body=sub%20tech>
>List-Unsubscribe: <mailto:majordomo@openbsd.org?body=unsub%20tech>
>X-Loop: tech@openbsd.org
>Precedence: list
>Sender: owner-tech@openbsd.org
>
>unveilcommands() is only used within doas.c and is not declared
>in doas.h. Make it static, per style(9).
>
>Index: doas.c
>===================================================================
>RCS file: /cvs/src/usr.bin/doas/doas.c,v
>diff -u -p -u -r1.99 doas.c
>--- doas.c 15 Feb 2024 18:57:58 -0000 1.99
>+++ doas.c 3 May 2026 13:33:43 -0000
>@@ -264,7 +264,7 @@ good:
> }
> }
>
>-int
>+static int
> unveilcommands(const char *ipath, const char *cmd)
> {
> char *path = NULL, *p;
>
>
doas: make unveilcommands() static