Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: bgpd: fix reload issue with templated peers
To:
tech@openbsd.org
Date:
Thu, 7 May 2026 16:45:22 +0200

Download raw body.

Thread
On Thu, May 07, 2026 at 04:42:06PM +0200, Claudio Jeker wrote:
> Stupid copy paste error. Use the right variable (xp) to check if the peer
> has a RDE session open or not.  In the end also xp->conf is shipped in the
> imsg.

ok

> 
> -- 
> :wq Claudio
> 
> Index: session.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/bgpd/session.c,v
> diff -u -p -r1.531 session.c
> --- session.c	7 May 2026 09:17:27 -0000	1.531
> +++ session.c	7 May 2026 14:40:00 -0000
> @@ -1960,7 +1960,7 @@ merge_peers(struct bgpd_config *c, struc
>  				session_template_clone(xp, NULL, xp->conf.id,
>  				    xp->conf.remote_as);
>  
> -				if (p->rdesession)
> +				if (xp->rdesession)
>  					imsg_rde(IMSG_SESSION_ADD,
>  					    xp->conf.id, &xp->conf,
>  					    sizeof(xp->conf));
>