On Wed, May 20, 2026 at 02:20:48PM +0200, Claudio Jeker wrote:
> The current handling of RTR min-version is not complete.
> In rtr_parse_header() there is an implicit downgrade path that I missed
> when introducing min_version.
> 
> So check min_version in the implict downgrade case and error out if the
> suggested version is too low. Also trigger the RTR_EVNT_NEGOTIATION_DONE
> event only after parsing all of the header. If the PDU was bad don't
> trigger this event.
> 
> In the rtr_fsm() when closing a connection check the state of the
> active_lock and if the lock is held, reset the cache, release the lock and
> recalculate the sets. The internal state is corrupt if a connection error
> triggerd during an exchange so it makes no sense to carry a bad cache
> around.

Can't spot anything wrong with this.

ok tb