Index | Thread | Search

From:
Theo Buehler <tb@theobuehler.org>
Subject:
Re: relayd: knfmt
To:
Rafael Sadowski <rafael@sizeofvoid.org>
Cc:
tech@openbsd.org
Date:
Mon, 15 Jun 2026 12:16:02 +0200

Download raw body.

Thread
  • Rafael Sadowski:

    relayd: knfmt

    • Theo Buehler:

      relayd: knfmt

On Mon, Jun 15, 2026 at 06:55:51AM +0200, Rafael Sadowski wrote:
> Here is a simple diff after running "knfmt -i *.c *.h". I'm by no means
> a KNF expert, nor do I have much experience with this. To me, it looks
> fine on the whole.
> 
> Obviously, I don't like 1 or 2 changes, but I prefer to set them to a
> "default" output of knfmt once and then I don't have to worry about them
> so much.

Yeah. Some of it are clear and obvious improvements, other changes not
so much. A lot of it is just a matter of taste. I like knfmt and don't
see anything deeply objectionable in your diff.

By this time I think you've earned maintainership of this code base,
so shrug. Whatever floats your boat :)

ok by me