Index | Thread | Search

From:
Claudio Jeker <cjeker@diehard.n-r-g.com>
Subject:
Re: amd64: clean up leftover from wbinvd_on_all_cpus() retirement
To:
tech@openbsd.org
Date:
Tue, 28 Jul 2026 16:29:23 +0200

Download raw body.

Thread
On Tue, Jul 28, 2026 at 04:20:17PM +0200, hshoexer wrote:
> Hi,
> 
> I forgot to remove wbinvd_on_all_cpus() for the single processor
> case.
> 
> see https://github.com/openbsd/src/commit/30ee307006ea2c1a918266c40b3f38154419645f
> 
> ok?

OK claudio@
 
> diff --git a/sys/arch/amd64/include/cpufunc.h b/sys/arch/amd64/include/cpufunc.h
> index 61718c4cea2..10616f6c688 100644
> --- a/sys/arch/amd64/include/cpufunc.h
> +++ b/sys/arch/amd64/include/cpufunc.h
> @@ -311,13 +311,6 @@ wbinvd_on_all_cpus(void)
>  	wbinvd();
>  	return 0;
>  }
> -
> -static inline int
> -wbinvd_on_all_cpus_acked(void)
> -{
> -	wbinvd();
> -	return 0;
> -}
>  #endif /* MULTIPROCESSOR */
>  
>  static __inline void
> 

-- 
:wq Claudio