Index | Thread | Search

From:
Rafael Sadowski <rafael@sizeofvoid.org>
Subject:
Re: iked, httpd, relayd, snmpd proc.c use correct type for imsgbuf_get
To:
tech@openbsd.org
Date:
Mon, 3 Aug 2026 13:09:00 +0200

Download raw body.

Thread
On Mon Aug 03, 2026 at 11:16:42AM +0200, Claudio Jeker wrote:
> imsgbuf_get() returns int, so adjust the type of 'n' to int.
> In all proc_dispatch() functions n is never reused for anything else.
> 

OK rsadowski

> -- 
> :wq Claudio
> 
> Index: sbin/iked/proc.c
> ===================================================================
> RCS file: /cvs/src/sbin/iked/proc.c,v
> diff -u -p -r1.55 proc.c
> --- sbin/iked/proc.c	16 Jul 2026 09:35:40 -0000	1.55
> +++ sbin/iked/proc.c	30 Jul 2026 12:05:36 -0000
> @@ -610,7 +610,7 @@ proc_dispatch(int fd, short event, void 
>  	struct privsep		*ps = p->p_ps;
>  	struct imsgbuf		*ibuf;
>  	struct imsg		 imsg;
> -	ssize_t			 n;
> +	int			 n;
>  	int			 ver;
>  	const char		*title;
>  	struct privsep_fd	 pf;
> Index: usr.sbin/httpd/proc.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/httpd/proc.c,v
> diff -u -p -r1.58 proc.c
> --- usr.sbin/httpd/proc.c	14 Jul 2026 08:30:09 -0000	1.58
> +++ usr.sbin/httpd/proc.c	30 Jul 2026 12:05:36 -0000
> @@ -580,7 +580,7 @@ proc_dispatch(int fd, short event, void 
>  	struct privsep		*ps = p->p_ps;
>  	struct imsgbuf		*ibuf;
>  	struct imsg		 imsg;
> -	ssize_t			 n;
> +	int			 n;
>  	int			 ver;
>  	const char		*title;
>  	struct privsep_fd	 pf;
> Index: usr.sbin/relayd/proc.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/relayd/proc.c,v
> diff -u -p -r1.60 proc.c
> --- usr.sbin/relayd/proc.c	14 Jul 2026 08:30:09 -0000	1.60
> +++ usr.sbin/relayd/proc.c	30 Jul 2026 12:05:36 -0000
> @@ -593,7 +593,7 @@ proc_dispatch(int fd, short event, void 
>  	struct privsep		*ps = p->p_ps;
>  	struct imsgbuf		*ibuf;
>  	struct imsg		 imsg;
> -	ssize_t			 n;
> +	int			 n;
>  	int			 ver;
>  	const char		*title;
>  	struct privsep_fd	 pf;
> Index: usr.sbin/snmpd/proc.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/snmpd/proc.c,v
> diff -u -p -r1.44 proc.c
> --- usr.sbin/snmpd/proc.c	16 Jul 2026 09:35:40 -0000	1.44
> +++ usr.sbin/snmpd/proc.c	30 Jul 2026 12:05:36 -0000
> @@ -601,7 +601,7 @@ proc_dispatch(int fd, short event, void 
>  	struct privsep		*ps = p->p_ps;
>  	struct imsgbuf		*ibuf;
>  	struct imsg		 imsg;
> -	ssize_t			 n;
> +	int			 n;
>  	int			 ver;
>  	const char		*title;
>  	struct privsep_fd	 pf;
>