Index | Thread | Search

From:
Alexander Bluhm <bluhm@openbsd.org>
Subject:
Re: dead code tells no tales, 14/16
To:
Miod Vallat <miod@online.fr>
Cc:
tech@openbsd.org
Date:
Mon, 21 Sep 2026 20:37:34 +0200

Download raw body.

Thread
On Sun, Sep 20, 2026 at 09:11:47PM +0000, Miod Vallat wrote:
> This routine does not appear to be used anywhere.

OK bluhm@

> Index: sys/netinet/ip_spd.c
> ===================================================================
> RCS file: /OpenBSD/src/sys/netinet/ip_spd.c,v
> diff -u -p -u -p -r1.122 ip_spd.c
> --- sys/netinet/ip_spd.c	8 Jul 2025 00:47:41 -0000	1.122
> +++ sys/netinet/ip_spd.c	20 Sep 2026 16:47:44 -0000
> @@ -42,7 +42,6 @@ int	ipsp_acquire_sa(struct ipsec_policy 
>  int	ipsp_pending_acquire(struct ipsec_policy *, union sockaddr_union *);
>  void	ipsp_delete_acquire_timer(void *);
>  void	ipsp_delete_acquire_locked(struct ipsec_acquire *);
> -void	ipsp_delete_acquire(struct ipsec_acquire *);
>  void	ipsp_unref_acquire_locked(struct ipsec_acquire *);
>  
>  struct pool ipsec_policy_pool;
> @@ -718,14 +717,6 @@ ipsp_delete_acquire_timer(void *v)
>  /*
>   * Delete a pending IPsec acquire record.
>   */
> -void
> -ipsp_delete_acquire(struct ipsec_acquire *ipa)
> -{
> -	mtx_enter(&ipsec_acquire_mtx);
> -	ipsp_delete_acquire_locked(ipa);
> -	mtx_leave(&ipsec_acquire_mtx);
> -}
> -
>  void
>  ipsp_delete_acquire_locked(struct ipsec_acquire *ipa)
>  {
> 
>