Index | Thread | Search

From:
Crystal Kolipe <kolipe.c@exoticsilicon.com>
Subject:
Re: rasops32: fix fonts on byte swapped framebuffers
To:
Ted Bullock <tbullock@comlore.com>
Cc:
tech@openbsd.org
Date:
Sat, 10 Oct 2026 09:48:04 -0000

Download raw body.

Thread
On Fri, Oct 09, 2026 at 09:41:37AM -0600, Ted Bullock wrote:
> Here is your version with unsigned colours and the pixel pair order adjusted
> for both CPU byte order and RI_BSWAP. The existing drawing loops are unchanged.

This looks correct, but we are missing a preprocessor #if :

> +	/* A byte swapped framebuffer reverses the two pixels together. */
> +	first_high = BYTE_ORDER == BIG_ENDIAN;

#if NRASOPS_BSWAP > 0

> +	if (ri->ri_flg & RI_BSWAP)
> +		first_high = !first_high;

#endif