Index | Thread | Search

From:
Ted Bullock <tbullock@comlore.com>
Subject:
Re: getty: check login_tty() failure
To:
Theo de Raadt <deraadt@openbsd.org>
Cc:
tech@openbsd.org
Date:
Sun, 11 Oct 2026 15:11:23 -0600

Download raw body.

Thread
Hi Theo,

I was working on the sparc radeon KMS handoff and testing transitions into
and out of X. During that testing, console login stopped working getty
couldn't grab the terminal and kept exiting and restarting. I haven't
established what caused it or which transition triggered it.

While diagnosing that, I noticed the unchecked login_tty() return value
since Getty continued after login_tty() failed, then reported a secondary
error from tcgetattr(). I thought checking the return value and exiting
reporting as soon as possible after the the original error was a reasonable
change even if it didn't have anything to do with whatever glitched or broke.

I haven't been able to reproduce the problem so i'm going to move on for now.