Index | Thread | Search

From:
Stefan Sperling <stsp@stsp.name>
Subject:
Re: uncm(4): process all notifications in one interrupt transfer
To:
Jan Schreiber <jes@posteo.de>
Cc:
David Gwynne <david@gwynne.id.au>, Mikolaj Kucharski <mikolaj@kucharski.name>, tech@openbsd.org
Date:
Wed, 14 Oct 2026 13:05:10 +0200

Download raw body.

Thread
On Wed, Oct 14, 2026 at 10:02:56AM +0000, Jan Schreiber wrote:
> On Tue, Oct 13, 2026 at 01:27:54PM +1000, David Gwynne wrote:
> > if struct usb_cdc_notification is only defined in terms of uByte,
> > uWord, and uDWord members (which is is), and only accessed with
> > UGETW and UGETDW (which i think it is) then it's already safe to
> > access on at any offset on big endian and/or strict alignment archs.
> > see the top of src/sys/dev/usb/usb.h.
> 
> In that case I'm happy to OK (for what its worth) Mikolajs original
> diff. Thank you for pointing it out, David!

I had missed these compatibilty macros as well, thanks.

I have committed the original diff.