Index | Thread | Search

From:
Miod Vallat <miod@online.fr>
Subject:
kernel: dead code in bio(4)
To:
tech@openbsd.org
Date:
Sat, 24 Oct 2026 17:51:56 +0000

Download raw body.

Thread
  • Miod Vallat:

    kernel: dead code in bio(4)

bio_{info,warn,error} wrappers around bio_status are not used anywhere,
all bio users invoke bio_status directly.

Index: dev/bio.c
===================================================================
RCS file: /OpenBSD/src/sys/dev/bio.c,v
diff -u -p -r1.20 bio.c
--- dev/bio.c	11 Aug 2026 16:25:29 -0000	1.20
+++ dev/bio.c	24 Oct 2026 17:51:01 -0000
@@ -186,36 +186,6 @@ bio_delegate_ioctl(struct bio_mapping *b
 }
 
 void
-bio_info(struct bio_status *bs, int print, const char *fmt, ...)
-{
-	va_list	ap;
-
-	va_start(ap, fmt);
-	bio_status(bs, print, BIO_MSG_INFO, fmt, &ap);
-	va_end(ap);
-}
-
-void
-bio_warn(struct bio_status *bs, int print, const char *fmt, ...)
-{
-	va_list	ap;
-
-	va_start(ap, fmt);
-	bio_status(bs, print, BIO_MSG_WARN, fmt, &ap);
-	va_end(ap);
-}
-
-void
-bio_error(struct bio_status *bs, int print, const char *fmt, ...)
-{
-	va_list	ap;
-
-	va_start(ap, fmt);
-	bio_status(bs, print, BIO_MSG_ERROR, fmt, &ap);
-	va_end(ap);
-}
-
-void
 bio_status_init(struct bio_status *bs, struct device *dv)
 {
 	bzero(bs, sizeof(struct bio_status));
Index: dev/biovar.h
===================================================================
RCS file: /OpenBSD/src/sys/dev/biovar.h,v
diff -u -p -r1.46 biovar.h
--- dev/biovar.h	7 Jun 2020 16:51:43 -0000	1.46
+++ dev/biovar.h	24 Oct 2026 17:51:01 -0000
@@ -303,10 +303,6 @@ void	bio_unregister(struct device *);
 
 void	bio_status_init(struct bio_status *, struct device *);
 void	bio_status(struct bio_status *, int, int, const char *, va_list *);
-
-void	bio_info(struct bio_status *, int, const char *, ...);
-void	bio_warn(struct bio_status *, int, const char *, ...);
-void	bio_error(struct bio_status *, int, const char *, ...);
 #endif
 
 #endif /* _SYS_DEV_BIOVAR_H_ */