Index | Thread | Search

From:
Miod Vallat <miod@online.fr>
Subject:
pppx/pppac: dead code
To:
tech@openbsd.org
Date:
Sat, 24 Oct 2026 20:47:44 +0000

Download raw body.

Thread
  • Miod Vallat:

    pppx/pppac: dead code

There is a pppacattach() routine, but since there is no pseudo-device
pppac in the kernel, it is never called.

This does not matter, as all it does is a subset of pppxattach(), and
there is pseudo-device pppx in the kernel, therefore pppxattach() runs
and takes care of things.

Index: net/if_pppx.c
===================================================================
RCS file: /OpenBSD/src/sys/net/if_pppx.c,v
diff -u -p -r1.135 if_pppx.c
--- net/if_pppx.c	7 Jul 2025 02:28:50 -0000	1.135
+++ net/if_pppx.c	24 Oct 2026 20:45:39 -0000
@@ -1016,12 +1016,6 @@ pppac_lookup(dev_t dev)
 	return (NULL);
 }
 
-void
-pppacattach(int n)
-{
-	pipex_init(); /* to be sure, to be sure */
-}
-
 int
 pppacopen(dev_t dev, int flags, int mode, struct proc *p)
 {