Index | Thread | Search

From:
Mikolaj Kucharski <mikolaj@kucharski.name>
Subject:
Re: urtwn: power the RTL8188CU/8192CU off in urtwn_stop()
To:
tech@openbsd.org
Date:
Thu, 29 Oct 2026 20:08:33 +0000

Download raw body.

Thread
On Thu, Oct 29, 2026 at 08:04:34PM +0000, Mikolaj Kucharski wrote:
> @@ -452,6 +453,9 @@ urtwn_attach(struct device *parent, stru
>  	sc->sc_iface = uaa->iface;
>  
>  	sc->sc_sc.chip = urtwn_lookup(uaa->vendor, uaa->product)->chip;
> +	/* POWEROFF TEST: banner, remove before commit. */
> +	printf("%s: poweroff fix v1 (2026-10-27) applied\n",
> +	    sc->sc_dev.dv_xname);
>  
>  	usb_init_task(&sc->sc_task, urtwn_task, sc, USB_TASK_TYPE_GENERIC);
>  	timeout_set(&sc->scan_to, urtwn_scan_to, sc);

Ah, I took it directly what I was running, forgot to clean it up. I'm
happy to clean up, but I also would like to get some feedback. Above
should be removed. Also source code comments are a bit verbose, so I am
happy to tune them as it is necesary for kernel adoption.

-- 
Regards,
 Mikolaj